Skip to content

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Sep 5, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 16fd0d8

Added a confirmation step for GitHub integration to verify the user's organization admin status. Modified the ConfirmDialog component to support customizations for different use cases.

🤖 Generated by Copilot at 16fd0d8

To connect with GitHub, you must state
If you're an admin of your org, mate
Use ConfirmDialog to show
A customized message, you know
With MessageBox parameters to create

Why

How

🤖 Generated by Copilot at 16fd0d8

  • Show a confirmation dialog before opening the GitHub installation URL in the connect function of github-connect.vue (link,link)
  • Add parameters to customize the appearance and behavior of the ConfirmDialog function in confirm-dialog.js (link,link,link,link,link,link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Sep 5, 2023
@joanagmaia joanagmaia self-assigned this Sep 5, 2023
@joanagmaia joanagmaia merged commit 5fda057 into main Sep 6, 2023
@joanagmaia joanagmaia deleted the improvement/github-alert branch September 6, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants