Skip to content

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Aug 30, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 12a4f78

Refactored and simplified the revenue range field in the organization form component. Used a computed option and helper functions to handle different formats and units for displaying revenue ranges. Removed unused code and imports.

🤖 Generated by Copilot at 12a4f78

Sing, O Muse, of the skillful coder who refined
The form and logic of the revenue range field,
And by his cunning mind and nimble fingers designed
A simpler and more elegant solution to wield.

Why

How

🤖 Generated by Copilot at 12a4f78

  • Simplify and refactor the revenue range field for the organization form (link, link, link, link)
  • Use a single el-option component with a computed value and label from the revenueRange module in organization-form-details.vue (link)
  • Remove the unused revenueRangesOptions array and import the default export of the revenueRange module instead in organization-form-details.vue (link)
  • Define two helper functions getValue and getMiddle to format the revenue range value and separator in revenueRange.ts (link)
  • Update the displayValue function to use the helper functions and handle the empty object case in revenueRange.ts (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Aug 30, 2023
@joanagmaia joanagmaia requested a review from skwowet August 30, 2023 10:13
@joanagmaia joanagmaia self-assigned this Aug 30, 2023
@joanagmaia joanagmaia changed the title Fix revenueRange display Fix organizations enrichment issues Aug 30, 2023
Copy link
Member

@skwowet skwowet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joanagmaia looks good to me!

@skwowet skwowet requested a review from themarolt August 30, 2023 10:54
@skwowet skwowet merged commit 62cd1d9 into main Aug 30, 2023
@skwowet skwowet deleted the bugfix/organizations-enrichment branch August 30, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants