Skip to content

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Jul 31, 2023

What

🤖 Generated by Copilot at 8702d75

The pull request improves the weekly analytics email feature by using a service class to format the activity descriptions and by shortening the email content. It also fixes a potential bug in the ActivityDisplayService class by adding a condition to check for the presence of activity attributes.

🤖 Generated by Copilot at 8702d75

We are the masters of display
We control the icons and the colors
We summon the attributes of the activity
Or we cast them into the void

Why

How

🤖 Generated by Copilot at 8702d75

  • Replace prettyActivityTypes object with ActivityDisplayService class to provide more flexible and consistent display options for activity types in weekly analytics email (link, link, link, link)
  • Reduce the limit of top conversation starters for each segment from 5 to 3 in weeklyAnalyticsEmailsWorker.ts to make the email more concise and focused (link)
  • Add condition to check if activity has attributes in ActivityDisplayService.getDisplayOptions method to prevent errors (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review July 31, 2023 09:28
@epipav epipav self-assigned this Jul 31, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Jul 31, 2023
@epipav epipav requested a review from garrrikkotua July 31, 2023 09:28
@epipav epipav merged commit 8388364 into main Jul 31, 2023
@epipav epipav deleted the bugfix/weekly-emails-display-fixes branch July 31, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants