Skip to content

Conversation

skwowet
Copy link
Member

@skwowet skwowet commented Jul 27, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 7b13f36

This pull request adds a new feature to edit the custom attributes of multiple members in bulk from the frontend. It also fixes some docker-compose and vite issues for the frontend development environment. The main changes are in the member-list-toolbar.vue and member-edit-attributes.vue components, and the scripts/services/frontend.yaml and frontend/package.json files.

🤖 Generated by Copilot at 7b13f36

To edit attributes in a snap
We added a new popover app
With vite updated
And docker paths set
The frontend is now a breeze to adapt

Why

How

🤖 Generated by Copilot at 7b13f36

  • Update vite dependency to fix dev server issues and improve performance (link)
  • Add new feature of editing attributes in bulk for selected members (link, link, link, link, link, link, link)
    • Create AppEditAttributesPopover component to show a dialog with a form for updating attributes (link)
    • Import and use AppEditAttributesPopover component in member-list-toolbar.vue (link, link)
    • Declare and use reactive variable bulkAttributesUpdateVisible to control dialog visibility (link)
    • Define and use handleEditAttributes function to handle user interaction for editing attributes (link, link)
  • Fix bug with docker-compose context path for frontend services (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet skwowet added the Improvement Created by Linear-GitHub Sync label Jul 27, 2023
@skwowet skwowet self-assigned this Jul 27, 2023
@skwowet skwowet changed the title Add support for bulk edit member attributes Support bulk edit member attributes Jul 27, 2023
@skwowet skwowet force-pushed the improvement/bulk-edit-member-attributes branch from 036da2f to 3343266 Compare July 31, 2023 19:12
@skwowet skwowet marked this pull request as ready for review August 4, 2023 12:44
@skwowet skwowet requested a review from joanagmaia August 4, 2023 12:45
@skwowet skwowet changed the title Support bulk edit member attributes Support bulk edit members attribute Aug 4, 2023
@skwowet skwowet merged commit 818adeb into CrowdDotDev:main Aug 4, 2023
@skwowet skwowet deleted the improvement/bulk-edit-member-attributes branch August 4, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants