Skip to content

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Jul 21, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 8a12c48

Added optional chaining operators to some expressions in githubIntegrationService.ts and activityTypes.ts to handle missing or undefined fields in GitHub pull request events. Added a truthy check for the domain variable in memberService.ts to prevent errors when finding organizations by email domains.

🤖 Generated by Copilot at 8a12c48

domain truthy check
avoiding errors in code
autumn of bugs ends

Why

How

🤖 Generated by Copilot at 8a12c48

  • Prevent errors when handling GitHub pull request events by adding optional chaining operators to record.actor.login, record.assignee.login, and activity.parent.title expressions in GithubIntegrationService class (link, link, link, link, link, link, link)
  • Improve data validation and error handling when finding organizations by email domains by checking the truthiness of domain variable before calling organizationService.findByUrl method in MemberService class (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua added the Bug Created by Linear-GitHub Sync label Jul 21, 2023
@garrrikkotua garrrikkotua merged commit 9a14dec into main Jul 21, 2023
@garrrikkotua garrrikkotua deleted the fix/github-undefined-errors branch July 21, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant