Skip to content

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Jul 6, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 5ec9a72

This pull request refactors the activity module by removing unused code and dependencies, simplifying the logic and the state management, improving the performance and the user feedback, and fixing some bugs. It also enhances the filter components and the LinkedIn integration. The main files affected are frontend/package-lock.json, frontend/package.json, frontend/src/modules/activity/*, frontend/src/assets/scss/filter.scss, frontend/src/integrations/linkedin/config.js.

🤖 Generated by Copilot at 5ec9a72

Oh we're the coders of the frontend crew
We refactor and we fix and we make it look new
We heave away the Vuex and we haul in the Pinia
And we sing as we work on the activity module

Why

How

🤖 Generated by Copilot at 5ec9a72

  • Remove unused dependency on filesize package from project configuration and lock files (link, link, link, link)
  • Delete unused files related to Vuex store (link, link, link, link, link, link)
  • Delete unused files related to activity list and filter components (link, link)
  • Delete unused file related to activity field definition (link)
  • Remove unused imports and fields from activity model file (link, link)
  • Remove unused imports and methods from activity service file (link, link, link)
  • Rename list method to query in activity service file (link)
  • Remove store import and export from activity module file (link)
  • Remove unused import and fix missing semicolon in activity timeline component file (link, link)
  • Remove unused import and action from activity dropdown component file (link, link)
  • Modify handleDestroy method in activity dropdown component file to use activity service and display message (link)
  • Modify fetchActivities action in activity Pinia store file to use query method (link)
  • Add SCSS code to improve appearance and functionality of filter components in filter.scss file (link)
  • Modify url function in LinkedIn integration configuration file to fix bug with undefined username (link)
  • Modify remotePopulateItems function in member filter configuration file to use listMembers method (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Jul 6, 2023
@joanagmaia joanagmaia requested a review from gaspergrom July 6, 2023 11:23
@joanagmaia joanagmaia self-assigned this Jul 6, 2023
@joanagmaia joanagmaia merged commit 5b401dc into main Jul 17, 2023
@joanagmaia joanagmaia deleted the improvement/clean-up-filters-code branch July 17, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants