Skip to content

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Jul 5, 2023

Changes proposed ✍️

Some github webhook body payloads have a size > 100kb - These webhooks were failing because of the default body size limit coming from the bodyParser. This size is now increased to 5MB

What

🤖 Generated by Copilot at 0bd1fbf

Increase API request body size limit for image uploads. Modify backend/src/api/index.ts to use bodyParser middleware with 5mb limit for JSON and URL-encoded requests.

🤖 Generated by Copilot at 0bd1fbf

We are the creators of the new world order
We defy the limits of the bodyParser
We unleash the power of the image upload
We are the masters of the JSON and URL-encoded

Why

How

🤖 Generated by Copilot at 0bd1fbf

  • Increase the maximum request body size for JSON and URL-encoded requests to 5mb to support image uploading (link, link) in backend/src/api/index.ts

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review July 5, 2023 13:18
@epipav epipav requested a review from themarolt July 5, 2023 13:19
@epipav epipav self-assigned this Jul 5, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Jul 5, 2023
@epipav epipav merged commit 376d4a5 into main Jul 5, 2023
@epipav epipav deleted the bugfix/request-body-size-limit branch July 5, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants