Skip to content

Conversation

sausage-todd
Copy link
Contributor

@sausage-todd sausage-todd commented Jul 4, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at ade62bf

Added a new dimension to track the platform of member activities, and moved and enriched some segments from the Organizations cube to the Members cube. This allows for better platform analysis of organization growth and engagement.

🤖 Generated by Copilot at ade62bf

Sing, O Muse, of the skillful coder who devised
A new dimension for the Members cube, to reveal
The varied platforms of their deeds, whether web or mobile,
And thus illuminate their habits and their zeal.

Why

How

🤖 Generated by Copilot at ade62bf

  • Add Activities.platform dimension to Members cube to enable filtering and grouping by activity source (link, link, link, link) in backend/src/cubejs/schema/Members.js

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@sausage-todd sausage-todd requested a review from epipav July 4, 2023 17:10
Copy link
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 Are the numbers correct with Activities.platform added to preaggs? Sometimes with one-many relationship it causes row duplication when hit by preaggs (meaning it might count same member twice when we include it in the preaggregation and when the member have multiple platform activities)

@sausage-todd sausage-todd force-pushed the feature/c-1745-selecting-a-platform-in-the-dashboard-results-in-long branch from ade62bf to 4920693 Compare July 6, 2023 13:43
Not use multiple many-to-many relationships at once, otherwise it leads
to data duplications and wrong numbers
@sausage-todd sausage-todd merged commit 6814c15 into main Jul 7, 2023
@sausage-todd sausage-todd deleted the feature/c-1745-selecting-a-platform-in-the-dashboard-results-in-long branch July 7, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants