Skip to content

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Jul 4, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at ee24fc6

Added support for segmenting users by different criteria in the data sink worker service. Refactored createActivityChannel method to use segmentId instead of tenantId and moved it to activity.service.ts.

🤖 Generated by Copilot at ee24fc6

We create the channels of doom
With segmentId we seal their fate
We move and refactor the code
To segment the users by hate

Why

How

🤖 Generated by Copilot at ee24fc6

  • Move and update createActivityChannel method to activity.service.ts file and query and update segments table instead of settings table (link, link, link, link)
  • Add segmentId parameter to createActivityChannel method to identify the segment that the activity belongs to (link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Jul 4, 2023
Copy link
Contributor

@sausage-todd sausage-todd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but similar things will happen again, because two different codebases share the same database.

@themarolt
Copy link
Contributor Author

Looks good, but similar things will happen again, because two different codebases share the same database.

@sausage-todd agree - eventually will deprecate the backend folder and remove it once everything is moved to services folder

@themarolt themarolt merged commit 1607252 into main Jul 4, 2023
@themarolt themarolt deleted the bugfix/segment-activity-channels branch July 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants