fixed where we update activityChannels (settings -> segments) #1071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at ee24fc6
Added support for segmenting users by different criteria in the data sink worker service. Refactored
createActivityChannel
method to usesegmentId
instead oftenantId
and moved it toactivity.service.ts
.
🤖 Generated by Copilot at ee24fc6
Why
How
🤖 Generated by Copilot at ee24fc6
createActivityChannel
method toactivity.service.ts
file and query and updatesegments
table instead ofsettings
table (link, link, link, link)segmentId
parameter tocreateActivityChannel
method to identify the segment that the activity belongs to (link, link, link)Checklist ✅
Feature
,Improvement
, orBug
.Add screehshots to the PR description for relevant FE changesNew backend functionality has been unit-tested.API documentation has been updated (if necessary) (see docs on API documentation).Quality standards are met.