Skip to content

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Jul 3, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at c4a1584

Added default pagination values to filter query service. This prevents errors when sending queries to the backend API and avoids modifying the original query object.

🤖 Generated by Copilot at c4a1584

setQuery adds
pagination defaults now
no mutation - spring

Why

How

🤖 Generated by Copilot at c4a1584

  • Add default pagination values to query object in setQuery function (link)
  • Use spread operator to avoid mutating original value argument in setQuery function (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Jul 3, 2023
@gaspergrom gaspergrom requested a review from joanagmaia July 3, 2023 08:21
@gaspergrom gaspergrom self-assigned this Jul 3, 2023
@gaspergrom gaspergrom merged commit 9a3f24e into main Jul 3, 2023
@gaspergrom gaspergrom deleted the bugfix/view-more-filters branch July 3, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants