Skip to content

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Jun 23, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 4415cd9

This pull request improves the performance and readability of the code related to members and their activities. It refactors the findByPlatformAndUsernames method in the memberRepository file to use more efficient queries and return more data. It also formats the dimensions array in the Members.js cube schema file to follow a consistent style.

🤖 Generated by Copilot at 4415cd9

memberRepository
Queries refactored, imports sorted
Spring cleaning the code

Why

How

🤖 Generated by Copilot at 4415cd9

  • Simplify and optimize the query for finding a member by platform and usernames in the memberRepository file (link, link, link)
  • Remove unused or redundant imports and sort them alphabetically in the memberRepository file (link, link, link, link)
  • Format the dimensions array in the MembersActivities cube schema for better readability in the Members.js file (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Improvement Created by Linear-GitHub Sync label Jun 23, 2023
@themarolt themarolt merged commit a0dc2d8 into main Jun 24, 2023
@themarolt themarolt deleted the member-exists-optimization branch June 24, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant