fix: Correct header highlighting for multi-byte characters #1385
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used
vim.fn.strwidth()
to calculate the end column for header highlighting. This function returns the display width, which can differ from the byte length when multi-byte characters like emojis are present.Since the
end_col
for extmarks expects a byte-based index, this caused the highlighting to be applied incorrectly.This patch corrects the issue by using the byte length (
#header_value
) for theend_col
of the highlight extmark, while still usingvim.fn.strwidth()
forvirt_text_win_col
to ensure correct visual alignment of UI elements.Fixes #1384