Remove accidental onMouseDown handler #5405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/07/2025, 02:55:34 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
DrJKL
previously approved these changes
Sep 7, 2025
dosubot
bot
added
size:M
|
It's a travesty that there's now green lines in the PR, but I've added a test that is harder to overwrite than the snapshots. |
DrJKL
approved these changes
Sep 7, 2025
christian-byrne
added
needs-backport
|
@AustinMroz Backport to Please manually cherry-pick commit Conflicting files
|
Merged
snomiao
pushed a commit
that referenced
this pull request
Sep 12, 2025
* Remove accidental onMouseDown handler * Fix test snapshot * Add test that onMouseDown isn't overwritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5079 removed the onMouseDown handler because it would overwrite prototype onMouseDown handlers added by custom nodes. This handler was accidentally re-added by #4263.
As the replacement mouse handling code added by #5079 still exists, only the removal of the onMouseDown code is required here.
EDIT: Looks like it also reverted test changes.
┆Issue is synchronized with this Notion page by Unito