[bugfix] Fix manager dialog warning banner close button visibility #5397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/07/2025, 04:48:52 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
viva-jinyi
added
area:manager
1.26
backport
|
What does it look like now? |
Before
After
It looks like while resolving the merge conflict, the original styles were overridden with different ones. I’ve corrected it so that it now matches the original styling. |
viva-jinyi
force-pushed
the
manager/close-icon-invisible
branch
from
9490e9a to
08d6afc
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 7, 2025
…5397) * feature: manager banner style fix * fix: light-theme color * fix: icon color modified for dark theme
|
@viva-jinyi Successfully backported to #5414 |
christian-byrne
pushed a commit
that referenced
this pull request
Sep 7, 2025
…5397) (#5414) * feature: manager banner style fix * fix: light-theme color * fix: icon color modified for dark theme Co-authored-by: Jin Yi <[email protected]>
snomiao
pushed a commit
that referenced
this pull request
Sep 12, 2025
…5397) * feature: manager banner style fix * fix: light-theme color * fix: icon color modified for dark theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
IconButtoncomponent for better consistencytop-0 right-0for proper alignmentbg-opacity-20to modern Tailwindbg-yellow-500/20Test Plan
Fixes visibility issue where close button was hard to see against warning banner background.
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito