Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 6, 2025

Adds ESLint rule to prevent usage of deprecated PrimeVue 4+ components and guide developers to modern replacements. This ensures code consistency and prevents accidental usage of outdated components during development.

Components Restricted

  • Dropdown → Select
  • OverlayPanel → Popover
  • Calendar → DatePicker
  • InputSwitch → ToggleSwitch
  • Sidebar → Drawer

The rule provides clear error messages with import guidance when deprecated components are detected.

┆Issue is synchronized with this Notion page by Unito

Adds no-restricted-imports rule to catch usage of deprecated PrimeVue 4+ components and guide developers to use their replacements:
- Dropdown → Select
- OverlayPanel → Popover
- Calendar → DatePicker
- InputSwitch → ToggleSwitch
- Sidebar → Drawer

This prevents accidental usage of deprecated components and ensures consistency across the codebase.
@christian-byrne christian-byrne requested a review from a team as a code owner September 6, 2025 09:42
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 6, 2025
@christian-byrne christian-byrne marked this pull request as draft September 6, 2025 09:52
Copy link

github-actions bot commented Sep 6, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 09/07/2025, 03:35:36 AM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

Adds TODO comment for future migration to Select component in SearchFilterDropdown.
@christian-byrne christian-byrne marked this pull request as ready for review September 6, 2025 19:08
DrJKL
DrJKL previously approved these changes Sep 7, 2025
benceruleanlu
benceruleanlu previously approved these changes Sep 7, 2025
Co-authored-by: Alexander Brown <[email protected]>
@christian-byrne christian-byrne dismissed stale reviews from benceruleanlu and DrJKL via 4cac57c September 7, 2025 03:25
@christian-byrne christian-byrne merged commit 20d4fe7 into main Sep 7, 2025
20 checks passed
@christian-byrne christian-byrne deleted the feat/add-eslint-rules-for-primevue-and-api-urls branch September 7, 2025 04:09
@benceruleanlu benceruleanlu mentioned this pull request Sep 7, 2025
snomiao pushed a commit that referenced this pull request Sep 12, 2025
* [feat] Add ESLint rule for deprecated PrimeVue components

Adds no-restricted-imports rule to catch usage of deprecated PrimeVue 4+ components and guide developers to use their replacements:
- Dropdown → Select
- OverlayPanel → Popover
- Calendar → DatePicker
- InputSwitch → ToggleSwitch
- Sidebar → Drawer

This prevents accidental usage of deprecated components and ensures consistency across the codebase.

* Add ESLint ignore for existing deprecated Dropdown usage

Adds TODO comment for future migration to Select component in SearchFilterDropdown.

* Update eslint.config.js

Co-authored-by: Alexander Brown <[email protected]>

---------

Co-authored-by: Alexander Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants