[refactor] Use public nodes getter instead of private _nodes property #5369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct access to graph._nodes with the public graph.nodes getter to follow proper encapsulation practices and avoid accessing private properties. Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/05/2025, 06:56:05 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
DrJKL
approved these changes
Sep 5, 2025
webfiltered
approved these changes
Sep 5, 2025
Merged
snomiao
pushed a commit
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace direct access to graph._nodes with the public graph.nodes getter to follow proper encapsulation.
Changes
graph.nodesgetter instead of accessing privategraph._nodesproperty in useSlotLayoutSyncReview Focus
Simple refactor to use the proper public API instead of accessing private properties.
┆Issue is synchronized with this Notion page by Unito