Skip to content

Conversation

benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Sep 5, 2025

Summary

Removes playwright mcp from devdependencies to silence Socket warning about obfuscated code in one of its dependencies.

Changes

  • What:
    Removes the playwright mcp and .mcp.json
  • Breaking:
    If you are relying on the playwright mcp or your own installed context7 mcp for this project, it might not work out of the box and you might have to install it yourself and configure the mcp yourself

Review Focus

Whether or not silencing the Socket warning about obfuscated code is worth losing the project-wide playwright mcp config

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu requested a review from a team as a code owner September 5, 2025 03:17
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 5, 2025
Copy link

github-actions bot commented Sep 5, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 09/05/2025, 04:47:20 PM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

Copy link

socket-security bot commented Sep 5, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedloglevel@​1.9.210010010078100
Addedlucide-vue-next@​0.540.01001009496100

View full report

DrJKL
DrJKL previously approved these changes Sep 5, 2025
christian-byrne
christian-byrne previously approved these changes Sep 5, 2025
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devs should set MCP config locally. I added this when CC first implemented MCP support and wasn't sure exactly the ergonomics of MCP configs in teams.

@benceruleanlu benceruleanlu dismissed stale reviews from christian-byrne and DrJKL via 460c955 September 5, 2025 16:34
@benceruleanlu benceruleanlu merged commit 091a3b3 into main Sep 5, 2025
19 checks passed
@benceruleanlu benceruleanlu deleted the bl-remove-playwright-mcp branch September 5, 2025 16:49
@benceruleanlu benceruleanlu mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants