Fix/toolbox node detection #5361
Conversation
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/05/2025, 12:12:08 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
|
You can still click the buttons though, right? |
|
Looks like playwright is failing due to an item within the toolbox, color picker. Checking out main, it is broken there as well. Not sure how its in main if playwright caught it here. Undoing my changes still shows it broken... I have a fix but not sure if I should roll it into this PR to appease playwright. Edit: patching now to pass tests. Will improve in a follow up. |
simula-r
added
the
New Browser Test Expectations
...ionToolbox.spec.ts-snapshots/selection-toolbox-multiple-selections-border-chromium-linux.png
Show resolved
Hide resolved
simula-r
force-pushed
the
fix/toolbox-node-detection
branch
from
b1b404e to
2cb5e63
Compare
simula-r
added
the
needs-backport
There was a problem hiding this comment.
Context on misleading test snapshot filename:
It clicks both text encode nodes
And the test implies that it's going to select the KSampler when in reality the select deselects the KSampler
Checking for the selection box's appearance and disappearance could catch a real issue
nit: A TODO or comment or change filename would be good
* refactor: dont need will change on animations * fix: by disabling parent pointer events and forcing on child element * fix: color picker watch with immediate option * Update test expectations [skip ci] --------- Co-authored-by: Jake Schroeder <[email protected]> Co-authored-by: github-actions <[email protected]>
* refactor: dont need will change on animations * fix: by disabling parent pointer events and forcing on child element * fix: color picker watch with immediate option * Update test expectations [skip ci] --------- Co-authored-by: Simula_r <[email protected]> Co-authored-by: Jake Schroeder <[email protected]> Co-authored-by: github-actions <[email protected]>
* refactor: dont need will change on animations * fix: by disabling parent pointer events and forcing on child element * fix: color picker watch with immediate option * Update test expectations [skip ci] --------- Co-authored-by: Jake Schroeder <[email protected]> Co-authored-by: github-actions <[email protected]>
Summary
Fix pointer events on SelectionToolbox to prevent unintended clicks on parent container by setting pointer-events: none on parent and pointer-events: auto on child Panel.
Review Focus
Fixes #5340
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito