Rework theme menu #5161
Merged
Rework theme menu #5161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/06/2025, 10:09:08 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 08/21/2025, 08:43:57 PM UTC 📊 Build Summary
🔗 Links🎉 Your Storybook is ready for review! |
PabloWiedemann
requested changes
Aug 21, 2025
There was a problem hiding this comment.
@pythongosssss this is great! love that you can switch between themes without the menu closing.
only small comment would be. Could we remove the divider between "Edit" and "View" ? 🙏
DrJKL
requested changes
Aug 21, 2025
pythongosssss
requested review from
Yorha4D,
KarryCharon,
shinshin86 and
a team
as code owners
dosubot
bot
added
the
size:L
Merged
snomiao
pushed a commit
that referenced
this pull request
Sep 12, 2025
* Change theme "button" to sub menu of all themes * Add test for theme menu * Prevent separator being added before View * Refactor test * Update locales [skip ci] * Fix has-text vs text-is change breaking other tests --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: bymyself <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the Theme button to a submenu with all available themes. Previously the theme button was overly prominent in the menu for how often it was used and only gave the ability to switch between light & dark.
Changes
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito