Skip to content

Less flaky tests when executing against remote server (not docker) #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Less flaky tests when executing against remote server (not docker) #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
918a7a0
MacOS less flaky tests
Enmk Sep 14, 2023
831c2f2
Same test filter for windows mingw run
Enmk Sep 14, 2023
f84a483
Same test filters for windows msvc run
Enmk Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ jobs:
# It is impossible to start CH server in docker on macOS due to github actions limitations,
# so we use remote server to execute tests, some do not allow some features for anonymoust/free users:
# - system.query_log used by 'Client/ClientCase.Query_ID'
GTEST_FILTER: "-Client/ClientCase.Query_ID*"
GTEST_FILTER: "-Client/ClientCase.Query_ID*:Client/ClientCase.TracingContext/*"
run: ./clickhouse-cpp-ut ${GTEST_FILTER}
2 changes: 1 addition & 1 deletion .github/workflows/windows_mingw.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
# It is impossible to start CH server in docker on Windows due to github actions limitations,
# so we use remote server to execute tests, some do not allow some features for anonymoust/free users:
# - system.query_log used by 'Client/ClientCase.Query_ID'
GTEST_FILTER: "-Client/ClientCase.Query_ID*"
GTEST_FILTER: "-Client/ClientCase.Query_ID*:Client/ClientCase.TracingContext/*"
run: ./build/ut/clickhouse-cpp-ut.exe ${GTEST_FILTER}

- name: Test (simple)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows_msvc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@ jobs:
# It is impossible to start CH server in docker on Windows due to github actions limitations,
# so we use remote server to execute tests, some do not allow some features for anonymoust/free users:
# - system.query_log used by 'Client/ClientCase.Query_ID'
GTEST_FILTER: "-Client/ClientCase.Query_ID*"
GTEST_FILTER: "-Client/ClientCase.Query_ID*:Client/ClientCase.TracingContext/*"
working-directory: ${{github.workspace}}/build/ut
run: Release\clickhouse-cpp-ut.exe "${{env.GTEST_FILTER}}"