Skip to content

fix #195 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2022
Merged

fix #195 #196

merged 2 commits into from
Jul 15, 2022

Conversation

romanholidaypancakes
Copy link
Contributor

@romanholidaypancakes romanholidaypancakes commented Jul 7, 2022 •
edited by Enmk
Loading

Maybe need to add a macro

closes: #195

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Enmk
Enmk reviewed Jul 12, 2022
View reviewed changes
Enmk
Enmk suggested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some background info to the PR: why it fails, maybe links to the corresponding docs?
Also, please address comments.

@Enmk Enmk merged commit b00a9ae into ClickHouse:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Enmk Enmk Enmk requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

windows connection database crash
3 participants
@romanholidaypancakes @CLAassistant @Enmk