-
Notifications
You must be signed in to change notification settings - Fork 185
Closed
Description
Hi Clickhouse Team:
When i update clickhouse-cpp to version 1.5.0. I build failed due to:
error C2668: 'signbit': ambiguous call to overloaded function
return std::signbit(v); |
I have a temporary workround, I want to know if it is feasible, or do you have a better solution?
diff --git a/clickhouse/columns/decimal.cpp b/clickhouse/columns/decimal.cpp
index 7334bb1..41d43b6 100644
--- a/clickhouse/columns/decimal.cpp
+++ b/clickhouse/columns/decimal.cpp
@@ -27,7 +27,7 @@ inline bool mulOverflow(const Int128 & l, const T & r, Int128 * result)
#else
template <typename T>
-inline bool getSignBit(const T & v)
+inline bool getSignBit(const T & (long double v))
{
return std::signbit(v);
}
Related pr #18330
myuanz and shubhamranjan
Metadata
Metadata
Assignees
Labels
No labels