OLED-246 - refactor and add eks enricher for account id and account group #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskerv
changed the title
jaskerv
commented
Feb 9, 2023
enricher/mappings/mappings.go
Outdated
|
|
||
| const ( | ||
| RESOURCE_CLOUD_ACCOUNT_ID = "cloud.account.id" | ||
| RESOURCE_ACCOUNT_GROUP = "account_group" |
There was a problem hiding this comment.
👋 @wimnat
How should we label the account group? Would this be fine under resource
There was a problem hiding this comment.
I think it works under resource alongside the account ID. 👍
There was a problem hiding this comment.
We decided that the account group function will fall under as canva.account.function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://canvadev.atlassian.net/browse/OLED-246
Description of changes:
Refactors how enricher works.