Skip to content

fix: avoid a warning about useless move #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2021
Merged

fix: avoid a warning about useless move #678

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5df1ee2
fix: avoid a warning about useless move
henryiii Nov 27, 2021
a0550f7
style: pre-commit.ci fixes
pre-commit-ci[bot] Nov 27, 2021
5cd99d2
Update include/CLI/App.hpp
henryiii Nov 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions include/CLI/App.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,27 +2252,24 @@ class App {

/// Process callbacks and such.
void _process() {
CLI::FileError fe("ne");
bool caught_error{false};
try {
// the config file might generate a FileError but that should not be processed until later in the process
// to allow for help, version and other errors to generate first.
_process_config_file();

// process env shouldn't throw but no reason to process it if config generated an error
_process_env();
} catch(const CLI::FileError &fe2) {
fe = fe2;
caught_error = true;
} catch(const CLI::FileError &) {
// callbacks and help_flags can generate exceptions which should take priority
// over the config file error if one exists.
_process_callbacks();
_process_help_flags();
throw;
}
// callbacks and help_flags can generate exceptions which should take priority over the config file error if one
// exists

_process_callbacks();
_process_help_flags();

if(caught_error) {
throw CLI::FileError(std::move(fe));
}

_process_requirements();
}

Expand Down