Skip to content

Conversation

henryiii
Copy link
Collaborator

This isn't my favorite solution, but it fixes #168 for now. The "forward" parsing bit (filling in prog --help sub so that it prints sub's help command) might not work well with custom callbacks, etc, since it runs the whole subcommand parse before continuing on.

A solution for 1.7.0 might be to break up _parse further into its components, then call them a bit more carefully.

@codecov
Copy link

codecov bot commented Sep 29, 2018

Codecov Report

Merging #169 into master will decrease coverage by 0.05%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage     100%   99.94%   -0.06%     
==========================================
  Files          12       12              
  Lines        1699     1712      +13     
==========================================
+ Hits         1699     1711      +12     
- Misses          0        1       +1
Impacted Files Coverage Δ
include/CLI/App.hpp 99.86% <92.3%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da901cc...6907b9a. Read the comment docs.

@henryiii henryiii merged commit 6bd31c3 into master Oct 21, 2018
@henryiii henryiii deleted the helpflag branch December 1, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"--help <subcommand>" runs subcommand
1 participant