Added OpenRouter support #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR under review ✅ Hope to revert by tonight. |
ishaan-jaff
reviewed
Jul 28, 2023
completion_test.py
Outdated
| print(response) | ||
|
|
||
| # # openai call | ||
| # response = completion(model="gpt-3.5-turbo", messages=messages) |
There was a problem hiding this comment.
can we leave all the other tests uncommented
There was a problem hiding this comment.
Will do in ~15 minutes. Thanks for reviewing 🧡
There was a problem hiding this comment.
Uncommented + deleted the unneeded testos.py (my bad) 🥲
One question - I could try implementing everything using pattern matching. Should I try that, or we'll lose backward compatibility this way?
There was a problem hiding this comment.
let's address pattern matching in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features