Skip to content

Conversation

alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Sep 15, 2025

globalThis can be undefined in a Native environment. (Why? I do not know yet :) ) In the meantime, this PR replaces it with the ancient, pre-ES2020 way of getting the global object.

@alexchuber alexchuber marked this pull request as draft September 15, 2025 22:32
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 15, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 16, 2025

@alexchuber alexchuber marked this pull request as ready for review September 16, 2025 17:32
@alexchuber alexchuber enabled auto-merge (squash) September 16, 2025 17:32
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blindly trusting you on this one :-)

@alexchuber alexchuber merged commit c339be0 into BabylonJS:master Sep 16, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants