[NetAppFiles] Beta bump to 2025-07-01-preview #52652
Open
+16,706
−2,309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure NetApp SDK to use the 2025-07-01-preview API version, bumping from the previous 2025-06-01 version. The update includes configuration changes for the API specification and introduces new quota-related functionality.
- Updates autorest configuration to use the 2025-07-01-preview API version
- Adds new quota limits path configuration
- Introduces NetApp subscription quota item model support
Reviewed Changes
Copilot reviewed 3 out of 149 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/netapp/Azure.ResourceManager.NetApp/src/autorest.md | Updates API spec version and commit hash, adds quota limits path, and includes quota item model mapping |
| sdk/netapp/Azure.ResourceManager.NetApp/src/Custom/Models/NetAppProvisioningState.cs | Adds new custom provisioning state model structure |
| sdk/netapp/Azure.ResourceManager.NetApp/src/Custom/ArmNetAppModelFactory.cs | Adds factory method for NetAppSubscriptionQuotaItem model |
sdk/netapp/Azure.ResourceManager.NetApp/src/Custom/Models/NetAppProvisioningState.cs
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
audunn
force-pushed
the
release-Microsoft.NetApp-2025-07-01-preview
branch
from
e56b91d to
69e3147
Compare
| System.Collections.Generic.IEnumerator<Azure.ResourceManager.NetApp.BucketResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.NetApp.BucketResource>.GetEnumerator() { throw null; } | ||
| System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; } | ||
| } | ||
| public partial class BucketData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.NetApp.BucketData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.BucketData> |
There was a problem hiding this comment.
this name is too generic and simple, could we make it more specific?
| @@ -1170,6 +1257,108 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer | |||
| string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BackupsMigrationContent>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | |||
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BackupsMigrationContent>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | |||
| } | |||
| public partial class BucketCredentialsExpiry : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.NetApp.Models.BucketCredentialsExpiry>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketCredentialsExpiry> | |||
There was a problem hiding this comment.
I think this name should follow the same change for model Bucket
| string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketCredentialsExpiry>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketCredentialsExpiry>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| public partial class BucketGenerateCredentials : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.NetApp.Models.BucketGenerateCredentials>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketGenerateCredentials> |
| string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketGenerateCredentials>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketGenerateCredentials>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| public partial class BucketPatch : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.NetApp.Models.BucketPatch>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketPatch> |
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketPatch>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | ||
| public readonly partial struct BucketPatchPermission : System.IEquatable<Azure.ResourceManager.NetApp.Models.BucketPatchPermission> |
| string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketServerPatchProperties>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketServerPatchProperties>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| public partial class BucketServerProperties : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.NetApp.Models.BucketServerProperties>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.BucketServerProperties> |
| @@ -1269,6 +1458,25 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer | |||
| public override string ToString() { throw null; } | |||
| } | |||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | |||
| public readonly partial struct CredentialsStatus : System.IEquatable<Azure.ResourceManager.NetApp.Models.CredentialsStatus> | |||
There was a problem hiding this comment.
this name is also quite generic, let us specify this.
| public static bool operator !=(Azure.ResourceManager.NetApp.Models.ExternalReplicationSetupStatus left, Azure.ResourceManager.NetApp.Models.ExternalReplicationSetupStatus right) { throw null; } | ||
| public override string ToString() { throw null; } | ||
| } | ||
| public partial class FileSystemUser : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.NetApp.Models.FileSystemUser>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.FileSystemUser> |
There was a problem hiding this comment.
this name is also kind of generic
| @@ -2619,6 +3018,18 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer | |||
| public static bool operator !=(Azure.ResourceManager.NetApp.Models.NetworkSiblingSetProvisioningState left, Azure.ResourceManager.NetApp.Models.NetworkSiblingSetProvisioningState right) { throw null; } | |||
| public override string ToString() { throw null; } | |||
| } | |||
| public partial class NfsUser : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.NetApp.Models.NfsUser>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NetApp.Models.NfsUser> | |||
There was a problem hiding this comment.
this name is also kind of generic
Comment on lines
+23
to
+24
| mgmt-debug: | ||
| show-serialized-names: true |
There was a problem hiding this comment.
please keep in mind that we need to disable this when everything is done and regenerate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.