[ConfidentialLedger] SDK validation for TypeSpec swagger #52626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
mzhongl524
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure ConfidentialLedger SDK to validate against a new TypeSpec swagger specification. The main change adds support for a new ScittConfiguration property in the ConfidentialLedger properties model.
- Adds a new
ScittConfigurationproperty to theConfidentialLedgerPropertiesmodel - Updates the autorest configuration to point to a new swagger specification commit
- Updates test code to properly handle the new property when creating ConfidentialLedger instances
Reviewed Changes
Copilot reviewed 4 out of 26 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| UpdateLedgerTest.cs | Updated test method to include the new ScittConfiguration property when creating ConfidentialLedgerProperties |
| autorest.md | Updated the swagger specification commit reference to the latest version |
| Azure.ResourceManager.ConfidentialLedger.netstandard2.0.cs | Added ScittConfiguration property to the public API surface |
ArcturusZhang
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the SDK validation for ConfidentialLedger.
TSP link: //github.com/Azure/azure-rest-api-specs/pull/34931.
Generate SDK code from Swagger and it seems that there are no significant changes.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.