Skip to content

webapp support api/settings from Kudu #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

webapp support api/settings from Kudu #1315

merged 1 commit into from
Nov 24, 2020

Conversation

weidongxu-microsoft
Copy link
Member

fix #1314

@weidongxu-microsoft
Copy link
Member Author

@Flanker32 for review.

I didn't get a good name for the API method. Currently call it getSiteAppSettings (or maybe getKuduAppSettings). Let me know if any better idea.

@Flanker32
Copy link
Contributor

@Flanker32 for review.

I didn't get a good name for the API method. Currently call it getSiteAppSettings (or maybe getKuduAppSettings). Let me know if any better idea.

@weidongxu-microsoft Thanks a lot for your efforts! I think getKuduAppSettings may be better but both are fine~

@weidongxu-microsoft
Copy link
Member Author

We will still use getSiteAppSettings, since previously we did not expose any method with "Kudu" in name (logStream, or zipDeploy).

@weidongxu-microsoft weidongxu-microsoft merged commit 32ec1ed into master Nov 24, 2020
@weidongxu-microsoft weidongxu-microsoft deleted the kudu-setting branch November 24, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenTanyi ChenTanyi Awaiting requested review from ChenTanyi

@yungezz yungezz Awaiting requested review from yungezz

1 more reviewer

@xseeseesee xseeseesee xseeseesee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] support get AppSetting from Kudu
3 participants
@weidongxu-microsoft @Flanker32 @xseeseesee