Fix background images and colors #363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AdamJ <[email protected]>
…oyment Co-authored-by: AdamJ <[email protected]>
Co-authored-by: AdamJ <[email protected]>
Co-authored-by: AdamJ <[email protected]>
github-actions
bot
added
dependencies
Deploying adamj-github-io with
|
| Latest commit: |
fb34674
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d22293a2.adamj-github-io.pages.dev |
| Branch Preview URL: | https://fix-small-bugs.adamj-github-io.pages.dev |
|
@copilot fix the build issues |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@copilot - can you fix the build errors? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken background CSS styling and simplifies the Font Awesome loading mechanism. The changes address background image sizing issues and streamline script loading across the site.
Key changes:
- Fixed hero background image sizing from
containtocoverfor proper display - Removed complex Font Awesome error handling in favor of direct script loading
- Cleaned up dark mode background color overrides that were causing visual issues
Reviewed Changes
Copilot reviewed 40 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/sass/_colors.scss | Removed forced dark background colors that were overriding theme styles |
| src/_includes/home.njk | Fixed hero background image sizing from contain to cover |
| src/_includes/footer.njk | Simplified Font Awesome loading by removing error handling wrapper |
| social/pages.json | Reordered page entries for social media generation |
| Multiple docs/*.html files | Applied Font Awesome script simplification across generated pages |
| Multiple feed/sitemap files | Updated timestamps and ordering from build regeneration |
| .stylelintrc.json & .stylelintignore | Enhanced linting configuration with better ignore patterns |
AdamJ
force-pushed
the
fix-small-bugs
branch
from
7487e46 to
12218e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken background CSS from prior PR along with dark background color.