Add cache_threshold to samplers.json -- use it if block caching is enabled #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rough update to allow for a
cache_thresholdfloat to be added to the sampler.json object.If it's present and block caching is turned on, then it uses that value instead of the default 0.2 or 0.12. If it is missing, then old behavior is the default.
Why
I was finding that I was tweaking these values for different samplers/schedulers as well as wanting a different value for live mode. This seemed like the simplest path to get the functionality I wanted. Not sure if it will fit within the big-picture plan for krita-ai, but wanted to share in case it was useful or would inspire a more proper implementation.