Fix typo in setup.py that prevents conda skeleton from parsing setup.py #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Just one tiny comma that needs to be moved downwards! * This breaks conda skeleton, which parses the pkginfo.yaml and doesn't expect a tuple/list there, see conda/conda-build#4227
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=======================================
Coverage 85.61% 85.61%
=======================================
Files 191 191
Lines 18212 18212
Branches 2071 2071
=======================================
Hits 15593 15593
Misses 2088 2088
Partials 531 531
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
If this is a result of thwarting the line length linter, can we turn off line length linting for the whole block to ease readability/maintainability? I feel like tricking a linter is an anti-pattern, and suppression is better. The proof, to my mind, is that it took some investigation to discover the typo. |
meshula
approved these changes
May 10, 2021
ssteinbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't made an issue since this is just fixing a typo, but I'm happy to open one if needed.
There's also a quick conversation on the Slack regarding this quirk, titled
conda & OTIO.Basically, in
setup.py, there's a tiny comma that needs to be moved downwards, otherwise it makes theotioautogen_serialized_schema_docs..entry a tuple made of one element, instead of a multiline string enclosed by parenthesis (which I suppose it was the original intent).Pinging @ssteinbach since I'm not a
setup.pyexpert and he originally authored that commit.The main reason why I discovered that is that it breaks
conda skeleton, which parses thepkginfo.yamlgenerated from thesetup.pyand doesn't expect a tuple/list there. See conda/conda-build#4227Thanks!
Valerio