Skip to content

Use Pybind11's find python tool to correctly locate python install information #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Use Pybind11's find python tool to correctly locate python install information #950

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b9f575
Fix: pip install works for third application's embeded python.
Tilix4 Apr 21, 2021
4fa7222
Added link to documentation
Tilix4 Apr 21, 2021
17ef31f
Fixed trailing whitespace
Tilix4 Apr 21, 2021
4f5ed43
FIxed line too long
Tilix4 Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ def cmake_generate():
'-DPYTHON_EXECUTABLE=' + sys.executable,
'-DOTIO_PYTHON_INSTALL:BOOL=ON',
'-DOTIO_CXX_INSTALL:BOOL=ON',
'-DCMAKE_BUILD_TYPE=' + ('Debug' if _ctx.debug else 'Release')
'-DCMAKE_BUILD_TYPE=' + ('Debug' if _ctx.debug else 'Release'),
'-DPYBIND11_FINDPYTHON=ON', # Smart tool to find python's libs: https://pybind11.readthedocs.io/en/latest/compiling.html#findpython-mode
]

python_inst_dir = get_python_lib()
Expand Down