-
Notifications
You must be signed in to change notification settings - Fork 309
Only load a manifest if it has not been loaded #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only load a manifest if it has not been loaded #945
Conversation
This all looks good to me. I did have two thoughts but in thinking about it more I don't know if they are really worth any changes:
I still wish I could track down what the "duplicate schema def" issue was and if we should be super strict about never allowing duplicates in any of these internal lists or not. |
@avrata I think this function could use a clean up pass and refactor how the manifests aggregate and are loaded. But this adds a check for relative vs absolute paths. |
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
==========================================
- Coverage 85.63% 85.61% -0.03%
==========================================
Files 191 191
Lines 18160 18204 +44
Branches 2061 2071 +10
==========================================
+ Hits 15552 15585 +33
- Misses 2085 2088 +3
- Partials 523 531 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks great! Thanks |
a291345
to
10b3def
Compare
- manifests could be listed with relative paths too, this makes all the paths absolute before checking them
- hard set it to use the __file__ attribute instead of relying on function to insert something meaningful.
143c105
to
44cfacc
Compare
Uh oh!
There was an error while loading. Please reload this page.