Skip to content

CMakeTexts fix: stop using the modname variable #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2021
Merged

CMakeTexts fix: stop using the modname variable #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/opentime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ target_include_directories(opentime PRIVATE "${PROJECT_SOURCE_DIR}/src")

set_target_properties(opentime PROPERTIES
DEBUG_POSTFIX "${OTIO_DEBUG_POSTFIX}"
LIBRARY_OUTPUT_NAME "${MODNAME}"
LIBRARY_OUTPUT_NAME "opentime"
POSITION_INDEPENDENT_CODE TRUE
WINDOWS_EXPORT_ALL_SYMBOLS true)

Expand Down
2 changes: 1 addition & 1 deletion src/opentimelineio/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ target_include_directories(opentimelineio PRIVATE
target_link_libraries(opentimelineio PUBLIC opentime)
set_target_properties(opentimelineio PROPERTIES
DEBUG_POSTFIX "${OTIO_DEBUG_POSTFIX}"
LIBRARY_OUTPUT_NAME "${MODNAME}"
LIBRARY_OUTPUT_NAME "opentimelineio"
POSITION_INDEPENDENT_CODE TRUE
WINDOWS_EXPORT_ALL_SYMBOLS true)

Expand Down
2 changes: 1 addition & 1 deletion src/py-opentimelineio/opentime-bindings/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ target_include_directories(_opentime
target_link_libraries(_opentime PUBLIC opentimelineio opentime)

set_target_properties(_opentime PROPERTIES
LIBRARY_OUTPUT_NAME "${MODNAME}"
LIBRARY_OUTPUT_NAME "_opentime"
DEBUG_POSTFIX "${OTIO_DEBUG_POSTFIX}")

# The version of pybind11 we are currently using generates an overwhelming number of
Expand Down
2 changes: 1 addition & 1 deletion src/py-opentimelineio/opentimelineio-bindings/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ target_compile_options(_otio PRIVATE
)

set_target_properties(_otio PROPERTIES
LIBRARY_OUTPUT_NAME "${modname}"
LIBRARY_OUTPUT_NAME "_otio"
DEBUG_POSTFIX "${OTIO_DEBUG_POSTFIX}")

if(APPLE)
Expand Down