ImageSequenceReference: Added handling for empty target_url_base #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equenceReference target_url_base has a trailing / (AcademySoftwareFoundation#890)
ssteinbach
requested changes
Feb 20, 2021
| ), | ||
| ) | ||
|
|
||
| assert ref.target_url_for_image_number(0) == 'myfilename.0101.exr' |
There was a problem hiding this comment.
Suggested change
| assert ref.target_url_for_image_number(0) == 'myfilename.0101.exr' | |
| self.assertEquals(ref.target_url_for_image_number(0), 'myfilename.0101.exr') |
There was a problem hiding this comment.
🤦 pytest muscle memory. Fixed.
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
=======================================
Coverage 86.65% 86.65%
=======================================
Files 183 183
Lines 17879 17883 +4
Branches 1972 1972
=======================================
+ Hits 15493 15497 +4
Misses 1902 1902
Partials 484 484
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ssteinbach
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890
Summarize your change.
There was a check to see if
target_url_baseended in a/to avoid having double-/ in constructed urls. This assumed `target_url_was of at lease length 1. Added a check to not attempt the check if the length is zero.Reference associated tests.
Added test checking generation of bare filenames using
target_url_for_image_number.