Skip to content

Fix ImageSequenceReference implicit cast #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Fix ImageSequenceReference implicit cast #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f3135
Explicitly cast size_t to int before comparison with frame_zero_padding.
reinecke Feb 19, 2021
0503942
Fixed a line in the README to be correct for both python 2 and 3.
reinecke Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ import opentimelineio as otio

timeline = otio.adapters.read_from_file("foo.aaf")
for clip in timeline.each_clip():
print clip.name, clip.duration()
print(clip.name, clip.duration())
```

There are more code examples here: https://github.com/PixarAnimationStudios/OpenTimelineIO/tree/master/examples
Expand Down
2 changes: 1 addition & 1 deletion src/opentimelineio/imageSequenceReference.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ ImageSequenceReference::ImageSequenceReference(std::string const& target_url_bas
std::string image_num_string = std::to_string(abs(file_image_num));

std::string zero_pad = std::string();
if (image_num_string.length() < _frame_zero_padding) {
if (static_cast<int>(image_num_string.length()) < _frame_zero_padding) {
zero_pad = std::string(_frame_zero_padding - image_num_string.length(), '0');
}

Expand Down