Fix Issue #881 #887
Merged
Fix Issue #881 #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not necessary to set C++11 flags for pybind11, that's already handled by cmake's C++ standard settings. Signed-off-by: Nick Porcino <[email protected]>
ssteinbach
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not necessary to set C++11 flags for pybind11, that's already
handled by cmake's C++ standard settings.
Signed-off-by: Nick Porcino [email protected]
Link the Issue(s) this Pull Request is related to.
Each PR should link at least one issue, in the form:
#881
Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.
Summarize your change.
Describe the reason for the change.
Add a list of changes, and note any that might need special attention during review.
Reference associated tests.
If no new tests are introduced as part of this PR, note the tests that are providing coverage.