Support --prefix correctly in new cmake system #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as far as our googling can tell, this was the only way we could find to get the value of the --prefix commandline argument supplied to setup.py.
- needed to change how paths get sent into the cmake part of the build - also moves the cxx-lib directory to be called cxx-sdk
- use the same logic for where the cxx-sdk location regardless of which branch through the setup.py is taken
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 86.63% 86.64%
=======================================
Files 183 183
Lines 17874 17875 +1
Branches 1971 1971
=======================================
+ Hits 15486 15487 +1
Misses 1904 1904
Partials 484 484
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
meshula
approved these changes
Feb 16, 2021
ssteinbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #885
Refactors how the setup.py communicates target locations to the cmake so that
--prefixand--userarguments are correctly handled.POTENTIALLY BREAKING CHANGE: Now if installing via
pip/setup.py, the C++ libraries are installed under the python install in acxx-sdkinstead ofcxx-libsdirectory.I'd like to note that the way of finding the value of the
--prefixargument is pretty gross. If there is a better/cleaner way, please let me know!