detect cycles #848
Merged
detect cycles #848
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshula
approved these changes
Dec 18, 2020
ssteinbach
reviewed
Jan 21, 2021
Comment on lines
+192
to
+196
| # Note: If we ever enable INSTANCING_SUPPORT in the C++ code, | ||
| # then modify the code below to be: | ||
| # oCopy = o.clone() | ||
| # self.assertTrue(oCopy is oCopy.metadata["myself"]) | ||
| with self.assertRaises(ValueError): |
There was a problem hiding this comment.
ah great, thanks for putting these comments in, very helpful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cycles in SerializableObjects cause crashes #847Modified the logic near #ifdef INSTANCING_SUPPORT to make use of the same table for checking for already encountered objects; however, because we only want to detect cycle and let mere instancing pass through (i.e. we don't demand things be a tree, we just demand they be acyclic) we remove an object from the table as we leave the function where we first encountered it.
In this way, we should be back to not being able to crash the system by writing bad Python code.
New tests (in tests.test_serializable_object.SerializableObjTest):
test_instancing_without_instancing_support
test_cycle_detection