Skip to content

Conversation

KarthikRIyer
Copy link
Contributor

@KarthikRIyer KarthikRIyer commented Jul 14, 2020

#659
Currently I have just updated the overlaps definition. I'll update contains tomorrow.

@KarthikRIyer
Copy link
Contributor Author

KarthikRIyer commented Jul 15, 2020

@meshula I've updated both the definitions. Please take a look.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good step for preciseness in implementation. It lgtm, but I'd like to get at least one other reviewer to look at it as well.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tightening this stuff up is great, and suggests the need for another convenience predicate: intersects -- see the notes in the reviews about that. Thanks for building all of this!

@KarthikRIyer
Copy link
Contributor Author

@ssteinbach PR updated.

inline constexpr bool greater_than_exclusive(lh, rh, epsilon)
I thought we could drop exclusive here because actually we're just comparing doubles and we could pass in exclusive or inclusive times. Does that make sense?

@ssteinbach
Copy link
Collaborator

Fixes #700

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@meshula
Copy link
Collaborator

meshula commented Aug 19, 2020

Looks like we can't use constexpr without more changes. Why don't we make greater_than and less_than inline for now?

 /tmp/pip-req-build-9j_a1bx9/src/opentime/timeRange.h:28:7: note: ‘opentime::v1_0::TimeRange’ is not literal because:
453   class TimeRange {
454         ^
455  /tmp/pip-req-build-9j_a1bx9/src/opentime/timeRange.h:28:7: note:   ‘opentime::v1_0::TimeRange’ is not an aggregate, does not have a trivial default constructor, and has no constexpr constructor that is not a copy or move constructor
456  /tmp/pip-req-build-9j_a1bx9/src/opentime/timeRange.h:319:27: error: enclosing class of constexpr non-static member function ‘bool opentime::v1_0::TimeRange::lesser_than(double, double, double) const’ is not a literal type
457       inline constexpr bool lesser_than(double lhs, double rhs, double epsilon) const{

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@ssteinbach ssteinbach added this to the Public Beta 13 milestone Aug 21, 2020
@meshula meshula merged commit 65ffe2a into AcademySoftwareFoundation:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants