-
Notifications
You must be signed in to change notification settings - Fork 309
Enforce stricter interval algebra rules for overlaps and contains #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce stricter interval algebra rules for overlaps and contains #760
Conversation
@meshula I've updated both the definitions. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good step for preciseness in implementation. It lgtm, but I'd like to get at least one other reviewer to look at it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tightening this stuff up is great, and suggests the need for another convenience predicate: intersects
-- see the notes in the reviews about that. Thanks for building all of this!
@ssteinbach PR updated.
|
and update trackAlgorithm accordingly.
and update trackAlgorithm accordingly
481fdc8
to
f248a43
Compare
Fixes #700 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Looks like we can't use constexpr without more changes. Why don't we make greater_than and less_than inline for now?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
#659
Currently I have just updated the
overlaps
definition. I'll updatecontains
tomorrow.