Skip to content

Conversation

KarthikRIyer
Copy link
Contributor

#745

This currently builds OTIO for Python 2.7, 3.6 & 3.7, and uploads the C++ build artefacts.

I still need to properly run coverage using tox.

@ssteinbach
Copy link
Collaborator

I suspect that if you follow the pattern of the travis.yml and run everything through tox, it might "just work":

https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/992b3c21d851b4ba815bf70fcae6ab9de3e174b0/.travis.yml#L12-L30

@jhodges10
Copy link
Collaborator

Great work on this! I was going to start working on it myself, but I see you've already done most of the work.
I'll do my best to review this some night this week and leave some feedback.

@ssteinbach
Copy link
Collaborator

@KarthikRIyer did you have a chance to try using tox for this? If you have trouble I can help you over slack get this working. Would love to get this into the mainline!

@KarthikRIyer
Copy link
Contributor Author

@ssteinbach not yet. I'll give this a try tomorrow and revert back. Currently facing some issues with my laptop.

@KarthikRIyer
Copy link
Contributor Author

@ssteinbach ssteinbach added this to the Public Beta 14 milestone Aug 21, 2020
@ssteinbach
Copy link
Collaborator

@KarthikRIyer one more dumb question about this -- this doesn't disable the travis runs, correct? It adds in the GitHub actions runs as well? That is what we would want, I think, so we can compare the two before turning travis back off.

@KarthikRIyer
Copy link
Contributor Author

@ssteinbach this doesn't affect Travis.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks Karthik!

@ssteinbach ssteinbach merged commit 30530a2 into AcademySoftwareFoundation:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants