-
Notifications
You must be signed in to change notification settings - Fork 309
Create GitHub Actions Workflow #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub Actions Workflow #752
Conversation
I suspect that if you follow the pattern of the travis.yml and run everything through tox, it might "just work": |
Great work on this! I was going to start working on it myself, but I see you've already done most of the work. |
@KarthikRIyer did you have a chance to try using |
@ssteinbach not yet. I'll give this a try tomorrow and revert back. Currently facing some issues with my laptop. |
PR updated. Coverage works now: https://github.com/KarthikRIyer/OpenTimelineIO/actions/runs/214134544 |
@KarthikRIyer one more dumb question about this -- this doesn't disable the travis runs, correct? It adds in the GitHub actions runs as well? That is what we would want, I think, so we can compare the two before turning travis back off. |
@ssteinbach this doesn't affect Travis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks Karthik!
#745
This currently builds OTIO for Python 2.7, 3.6 & 3.7, and uploads the C++ build artefacts.
I still need to properly run coverage using tox.