Skip to content

Conversation

vpinon
Copy link
Contributor

@vpinon vpinon commented Nov 13, 2019

Hello,
Here is a proposal to be able to inter-operate with the libre video editor Kdenlive.
I've run some successful tests on my side, and our community is waiting for such feature for long.
Please guide me if I have to do something more.
Many thanks for OpenTimelineIO!
BR,
Vincent

@apetrynet
Copy link
Contributor

This is cool! Will it support straight mlt files as well?

@vpinon
Copy link
Contributor Author

vpinon commented Nov 14, 2019

Hum, I was not aware of hard formatting rules enforcing, I will update it.
It will not eat any MLT file, it is expecting Kdenlive structure (which may match Shotcut too, but not checked)

@vpinon
Copy link
Contributor Author

vpinon commented Nov 17, 2019

I'm so sorry I should have read the contribution guide /o
Now make test & make lint pass correctly with python3.7

@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files          72       72           
  Lines        2732     2732           
=======================================
  Hits         2232     2232           
  Misses        500      500
Flag Coverage Δ
#py27 81.67% <ø> (ø) ⬆️
#py36 81.67% <ø> (ø) ⬆️
#py37 81.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d32687...f10a24e. Read the comment docs.

@vpinon
Copy link
Contributor Author

vpinon commented Nov 18, 2019

Finally OK!

@jminor
Copy link
Collaborator

jminor commented Nov 18, 2019

Hi @vpinon could you submit a Contributor License Agreement, as described here: https://opentimelineio.readthedocs.io/en/latest/tutorials/contributing.html

@vpinon
Copy link
Contributor Author

vpinon commented Nov 18, 2019

Yes sorry.
I will print & scan it tomorrow.
BR

Copy link
Collaborator

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us know if/when you're ready to land this PR.

@vpinon
Copy link
Contributor Author

vpinon commented Dec 3, 2019

It would be fine if merged as it is today.
We can always improve it later (e.g. effects & transitions handling) but nothing foreseen soon.
Many thanks!

@jminor jminor merged commit 409bdde into AcademySoftwareFoundation:master Dec 3, 2019
@jminor
Copy link
Collaborator

jminor commented Dec 3, 2019

Thanks for the contribution :)

@ssteinbach ssteinbach added this to the Public Beta 12 milestone Dec 13, 2019
andrewmoore-nz added a commit to andrewmoore-nz/OpenTimelineIO that referenced this pull request Jan 8, 2020
* master:
  Aaf adapter target url fix (AcademySoftwareFoundation#628)
  C++ Error documentation additions (AcademySoftwareFoundation#620)
  Issue 622 (AcademySoftwareFoundation#624)
  Add Kdenlive adapter (AcademySoftwareFoundation#618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants