#590: Process local adapter manifests before internal manifests #591
Conversation
There was a problem hiding this comment.
This looks good, nice and simple solution imo. I think you can click commit suggestion on some of the notes and the lint should pass. You can also run the linter locally with make lint.
Thanks @JoshBurnell!
|
|
||
| # set where to find the new manifest | ||
| os.environ['OTIO_PLUGIN_MANIFEST_PATH'] = otio_path.name | ||
| result = otio.plugins.manifest.load_manifest() |
There was a problem hiding this comment.
This unit test is great. But a note to self is that it might be nice to have a way to at run time add manifests on the path rather than doing it by manipulating the environment variable and calling load_manifest().
|
It looks like there is a conflict in manifest.py. Can you rebase on top of the latest master to resolve the conflict? Sorry about that. I suspect that is also why the unit test suite hasn't been run on this. |
|
Resolved. |
|
Or maybe not... hang on. |
|
There we go. |
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 72 72
Lines 2729 2729
=======================================
Hits 2229 2229
Misses 500 500
Continue to review full report at Codecov.
|
|
Great catch @JoshBurnell, thanks for fixing this! |
Reordered the processing of adapter manifests. Also fixed bug in Manifest.extend() which missed hook types if they weren't included at Manifest creation.