-
Notifications
You must be signed in to change notification settings - Fork 310
[WIP] Image reference schema suggestion #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Image reference schema suggestion #536
Conversation
* Added clip.trimmed_range() override to support ImageReference * Added tests case for ImageReference
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=========================================
- Coverage 88.8% 88.8% -0.01%
=========================================
Files 68 69 +1
Lines 7399 7433 +34
=========================================
+ Hits 6571 6601 +30
- Misses 828 832 +4
Continue to review full report at Codecov.
|
So, I realize the timing of this PR was quite bad (with the move to C++, SIGGRAPH and all), but has anyone had the chance to look at it and made any thoughts on it? Is it worth reproducing in C++? |
Hi @apetrynet! Yes, we did see this and a few people at SIGGRAPH mentioned the topic. Sorry for the delay in responding. As you mentioned, we were busy with the C++ port, and now we're beginning to move the project over to the Academy Software Foundation. That will involve forming a technical steering committee who can help us decide, as a community, about the roadmap. One of the key things that the roadmap needs to include is schema improvements like this. In effect that means that we're not quite ready to move forward with this yet, but we do hope to in the coming months. As for the specifics of your proposal, here are a few things that come to mind:
|
Hi!
In my experience, almost all image based plates in a VFX pipeline have frame numbers starting at something else than what the TC would imply. Usually 1001-1200 etc. I don't know all the history for this, but it makes life easier using the plate in software like Maya, Nuke etc. to keep the timeline at a standard range. I seem to recall Maya actually having an issue with timelines that had really high numbered ranges.
Sure. Went back and forth on this myself. I haven't thought it through well enough yet, but this could also be used for held single frames though.
Oh, yes. The everlasting debate on frame representation :)
True. I haven't thought about that yet. That's a tough one in any case. The TC duration could be "full length", but the data won't. How would this be reflected in other media? I think in a video container, this would remap the frame numbers to create a shortened video file.
Sure. Will add it to the PR |
@apetrynet As long as you're happy with #602 :) |
I'm confident we'll land a good solution with that one, yes :) |
Hi!
I thought I'd put together a suggestion for how to implement
ImageReference
as mentioned in #69Also added a test case to illustrate usage.
Let me know what you think.