Adding diff feature (otiodiff) to otiotool #1922
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
…in otiotool Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
…with video only, audio only, or both video and audio Signed-off-by: Yingjie Wang <[email protected]>
…moved tracks Signed-off-by: Yingjie Wang <[email protected]>
… timelineB display Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
…istence into timeline summary and updated variable/function names Signed-off-by: Yingjie Wang <[email protected]>
…tance variable names to be more descriptive, refactored test and diff scripts to match Signed-off-by: Yingjie Wang <[email protected]>
… typo in inspect example, and updated otiodiff function call from main to diff Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
…ed docstrings and updated variable/function naming Signed-off-by: Yingjie Wang <[email protected]>
…making tracks for A and B Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
…ne B for correct timing Signed-off-by: Yingjie Wang <[email protected]>
…processing Signed-off-by: Yingjie Wang <[email protected]>
…Datas Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
Signed-off-by: Yingjie Wang <[email protected]>
jminor
reviewed
Aug 21, 2025
| def __init__(self, source_clip, track_num, note=None): | ||
| self.full_name = source_clip.name | ||
| self.name = self.splitFullName(source_clip)[0] | ||
| self.version = self.splitFullName(source_clip)[1] |
There was a problem hiding this comment.
This could avoid calling the function twice:
self.name, self.version = self.splitFullName(source_clip)
jminor
reviewed
Aug 21, 2025
| @@ -0,0 +1,162 @@ | |||
| import opentimelineio as otio | |||
|
|
|||
| # TODO: clip comparable??? ClipInfo | |||
jminor
requested changes
Aug 21, 2025
There was a problem hiding this comment.
This is getting close!
Could you remove some of the blocks of commented-out code that you don't think would be useful to another person working on this later.
Let's walk through the remaining TODOs & either address them if they're quick, or turn them into "suggestion for future work".
Signed-off-by: Yingjie Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a diff feature that compares the clips of two OTIO timelines. Clips are categorized based on changes from timeline A to timeline B. Outputs an annotated and color coded OTIO with tracks from both timelines visualizing differences as well as a text summary.
Addresses #26
Demo-ed at 2025 ASWF OTIO Virtual Town Hall