Skip to content

Conversation

darbyjohnston
Copy link
Contributor

Fixes #1753

Summarize your change.

Adds Doxygen comments to the RationalTime class. These comments are based on the Python doc strings with some editing for consistency.

(This PR replaces #1746 which got into some git trouble.)

Signed-off-by: Darby Johnston <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.71%. Comparing base (c0e97b0) to head (9325b51).
Report is 57 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
- Coverage   84.11%   81.71%   -2.41%     
==========================================
  Files         198      176      -22     
  Lines       22241    12315    -9926     
  Branches     4687     3020    -1667     
==========================================
- Hits        18709    10063    -8646     
+ Misses       2610     1713     -897     
+ Partials      922      539     -383     
Flag Coverage Δ
py-unittests 81.71% <ø> (-2.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentime/rationalTime.h 92.55% <ø> (-2.13%) ⬇️

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10fdd2...9325b51. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@reinecke reinecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reinecke reinecke merged commit 0d04b04 into AcademySoftwareFoundation:main Jun 20, 2024
@reinecke reinecke added this to the Public Beta 17 milestone Jun 24, 2024
@darbyjohnston darbyjohnston deleted the doxygen2 branch April 27, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Doxygen comments to the C++ API
3 participants