Skip to content

Conversation

ssteinbach
Copy link
Collaborator

No description provided.

@ssteinbach ssteinbach added build issues building OTIO ci and removed build issues building OTIO labels Apr 13, 2024
@ssteinbach ssteinbach added this to the Public Beta 17 milestone Apr 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (c0e97b0) to head (527958c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1737   +/-   ##
=======================================
  Coverage   84.11%   84.11%           
=======================================
  Files         198      198           
  Lines       22241    22241           
  Branches     4687     4692    +5     
=======================================
  Hits        18709    18709           
  Misses       2610     2610           
  Partials      922      922           
Flag Coverage Δ
py-unittests 84.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e97b0...527958c. Read the comment docs.

@markreidvfx
Copy link
Contributor

I have the same fix in #1739. This PR can be dropped

@ssteinbach ssteinbach closed this Apr 15, 2024
@ssteinbach ssteinbach reopened this Apr 15, 2024
@ssteinbach
Copy link
Collaborator Author

@markreidvfx looks like the token way was still failing, trying via an env var now.

@ssteinbach ssteinbach merged commit a5682c0 into AcademySoftwareFoundation:main Apr 15, 2024
@ssteinbach ssteinbach deleted the main.codecov_token branch April 15, 2024 21:45
@markreidvfx
Copy link
Contributor

@ssteinbach I'm pretty sure token works. At least that how I got it working on my fork before I created the arm64 PR. using CODECOV_TOKEN never worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants