Skip to content

Conversation

ssteinbach
Copy link
Collaborator

@ssteinbach ssteinbach commented Apr 12, 2024

Codecov uploader is no longer compatible w/ python 3.7, which was causing action failures against the python 3.7 target. This switches it to use the 3.10 version of python instead. It also updates to the v4 codecov uploader.

* no longer compatible with 3.7
@ssteinbach ssteinbach requested a review from reinecke April 12, 2024 03:55
@ssteinbach ssteinbach added the build issues building OTIO label Apr 12, 2024
@ssteinbach ssteinbach added this to the Public Beta 17 milestone Apr 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (2b9c3a4) to head (f4679db).
Report is 62 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
+ Coverage   79.95%   84.11%   +4.16%     
==========================================
  Files         197      198       +1     
  Lines       21879    22241     +362     
  Branches     4342     4693     +351     
==========================================
+ Hits        17494    18709    +1215     
- Misses       2252     2610     +358     
+ Partials     2133      922    -1211     
Flag Coverage Δ
py-unittests 84.11% <ø> (+4.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 107 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5d7b5...f4679db. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ssteinbach ssteinbach changed the title move up codecov version to python 3.10 Update codecov to run on python 3.10 builds Apr 12, 2024
Copy link
Collaborator

@reinecke reinecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ssteinbach ssteinbach merged commit 9d875e7 into AcademySoftwareFoundation:main Apr 12, 2024
@ssteinbach ssteinbach deleted the update_codecov_python_version branch April 12, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build issues building OTIO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants